Skip to content

fix: Corrects memory leak in MessageRegistrationTests#2148

Merged
NoelStephensUnity merged 1 commit intodevelopfrom
fix/memory_leak_in_MessageRegistrationTests
Aug 24, 2022
Merged

fix: Corrects memory leak in MessageRegistrationTests#2148
NoelStephensUnity merged 1 commit intodevelopfrom
fix/memory_leak_in_MessageRegistrationTests

Conversation

@ShadauxCat
Copy link
Copy Markdown
Collaborator

Fixes a memory leak in MessageRegistrationTests that was causing occasional spurious failures in unrelated tests due to Collections memory leak detection + timing being linked to GC.

@ShadauxCat ShadauxCat requested a review from a team as a code owner August 24, 2022 22:41
Copy link
Copy Markdown
Member

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) August 24, 2022 23:02
@NoelStephensUnity NoelStephensUnity merged commit 2271d65 into develop Aug 24, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/memory_leak_in_MessageRegistrationTests branch August 24, 2022 23:20
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants